Update to read_framebuffer to allow compute presentation. #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qining
reviewed
Apr 24, 2018
gapis/api/vulkan/read_framebuffer.go
Outdated
|
|
||
| requestWidth := reqWidth | ||
| requestHeight := reqHeight | ||
|
|
||
| // Rendered image should always has a graphics-capable queue bound, if none |
|
Vulkan side looks good to me. |
ben-clayton
approved these changes
Apr 26, 2018
gapis/api/api.go
Outdated
| @@ -46,7 +46,7 @@ type API interface { | |||
| after []uint64, | |||
| state *GlobalState, | |||
| thread uint64, | |||
| attachment FramebufferAttachment) (width, height, index uint32, format *image.Format, err error) | |||
| attachment FramebufferAttachment) (width, height, index uint32, format *image.Format, canResize bool, err error) | |||
There was a problem hiding this comment.
There comes a point where a struct is preferred over N return values 😃. I suggest declaring a FramebufferAttachmentInfo struct in this file with Width, Height, Index, Format and CanResize fields.
AWoloszyn
force-pushed
the
compute-present
branch
from
5c39b3e
to
0849855
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does 2 things, first it allows us to copy out an image from a Vulkan compute queue.
Secondly it allows us to choose to not resize the images in the server. This is primarily so that the client can resample how it chooses rather than forcing us to do a software resize in GAPIS.