Do not stop if one unit test fails

[mshudrak]

Currently, our unit test process stops as soon as one test fails thereby making it hard to evaluate what else breaking without actually fixing the error and relaunching test again. We need to first run all tests and then print summary of failed functions.

[Pavan-Nambi]

hey is this issue still exists? if so can i work on this? a try catch blocks? or should i use unittest to keep consistency?

asking this as i see there is unittest.mock alrdy being used here

[mshudrak]

Oh yes, the issue still exist. Feel free to work on it. I was actually referring to this one: https://github.com/google/gcp_scanner/blob/main/src/gcp_scanner/test_unit.py. It fails as soon as the first assert is not satisfied. I'd use unittest.mock module to keep consistency.

[Pavan-Nambi]

oo ok gotcha

[jatinagwal]

@Pavan-Nambi Can I pick this up?

[Pavan-Nambi]

hey @jatinagwal yeah feel free to do so , i got into some work so wasn't able to do , appologies for delay

[sudiptob2]

I am also interested in this issue if it's open.

[sudiptob2]

@mshudrak I think its best practice to write single assert per test function. If you agree, I can take on the issue and refactor the tests.
I am looking forward to your opinion 🙂