Update README.md #50
Merged
Update README.md #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed typos and grammatical errors.
ZetaTwo
requested changes
Feb 25, 2023
README.md
Outdated
| @@ -32,9 +32,9 @@ The scanner supports extracting and using the following types of credentials: | |||
| * OAuth2 Refresh Token with cloud-platform scope granted; | |||
| * GCP service account key in JSON format. | |||
|
|
|||
| The scanner does not rely on any third-party tool (e.g. gcloud). Thus, it can be compiled as a standalone tool and be used on a machine with no GCP SDK installed (e.g. Kubernetes pod). However, please keep in mind that the only OS that is currently supported is Linux. | |||
| The scanner does not rely on any third-party tool (e.g., Gcloud). Thus, it can be compiled as a standalone tool and used on a machine with no GCP SDK installed (e.g., a Kubernetes pod). However, please keep in mind that the only OS that is currently supported is Linux. | |||
There was a problem hiding this comment.
gcloud is the name of the GCP CLI tool and should be kept lowercase.
There was a problem hiding this comment.
changed to gcloud
Updated the doc as per suggestion.
ZetaTwo
requested changes
Feb 26, 2023
README.md
Outdated
| @@ -32,9 +32,9 @@ The scanner supports extracting and using the following types of credentials: | |||
| * OAuth2 Refresh Token with cloud-platform scope granted; | |||
| * GCP service account key in JSON format. | |||
|
|
|||
| The scanner does not rely on any third-party tool (e.g. gcloud). Thus, it can be compiled as a standalone tool and be used on a machine with no GCP SDK installed (e.g. Kubernetes pod). However, please keep in mind that the only OS that is currently supported is Linux. | |||
| The scanner does not rely on any third-party tool (e.g., gcloud). Thus, it can be compiled as a standalone tool and used on a machine with no GCP SDK installed (e.g., a Kubernetes pod). However, please keep in mind that the only OS that is currently supported is Linux. | |||
There was a problem hiding this comment.
@ggold7046 please resolve this one so we can merge the PR.
Updated the doc as per suggestion.
Closed
mshudrak
requested changes
Mar 2, 2023
README.md
Outdated
| @@ -32,7 +32,7 @@ The scanner supports extracting and using the following types of credentials: | |||
| * OAuth2 Refresh Token with cloud-platform scope granted; | |||
| * GCP service account key in JSON format. | |||
|
|
|||
| The scanner does not rely on any third-party tool (e.g., gcloud). Thus, it can be compiled as a standalone tool and used on a machine with no GCP SDK installed (e.g., a Kubernetes pod). However, please keep in mind that the only OS that is currently supported is Linux. | |||
| The scanner does not rely on any third-party tool (e.g. gcloud). Thus, it can be compiled as a standalone tool and used on a machine with no GCP SDK installed (e.g., a Kubernetes pod). However, please keep in mind that the only OS that is currently supported is Linux. | |||
There was a problem hiding this comment.
there is another comma after e.g.
Updated as per suggstion.
|
LGTM but please resolve the conflicting files before we can merge. |
mshudrak
approved these changes
Mar 2, 2023
I don't know how to resolve this conflict. Could you guide me please ? |
|
Do you have button "resolve conflicts"? That's where you can do it basically.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed typos and grammatical errors.