You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the logic in convert_bhive_to_llvm_exegesis_input will create
extra (empty) files as the output at the end runs unconditionally rather
than when there are actually blocks to output. This means that if we
have a number of blocks that is an exact multiple of the value in
blocks_per_json_file, we end up getting no blocks after the loop, which
means we output an empty JSON file.
Fixesgoogle#61.
Currently, the logic in convert_bhive_to_llvm_exegesis_input will create
extra (empty) files as the output at the end runs unconditionally rather
than when there are actually blocks to output. This means that if we
have a number of blocks that is an exact multiple of the value in
blocks_per_json_file, we end up getting no blocks after the loop, which
means we output an empty JSON file.
Fixes#61.
Using the following CSV,
test.csv
:With the following command line invocation, assuming
./json
exists:We get the following in
./json
:Note that we should only get two files.
0.json
:1.json
:2.json
:We see one of the blocks duplicated, the second block shows up twice, we get an extra file, and the extra file is empty. This needs to be fixed.
The text was updated successfully, but these errors were encountered: