Add exegesis BB annotator #30
Conversation
This patch adds in an alternative to the existing find_accessed_addrs infrastructure that uses llvm-exegesis as a backend. We believe this will more closely match the execution environment of the benchmarking environment and should avoid some of the pitfalls of the existing memory annotation infrastructure (at the current expense of speed).
|
This should be pretty much good to go. llvm/llvm-project#74574 still needs to land for the comment mentioned above, but there shouldn't be any other issues. |
There was a problem hiding this comment.
Nice, thanks for working on this!
I have a bunch of changes in the existing tool that I need to push, and Owen keeps working on it. We need to eventually merge the two and keep the best from both versions (and then we should start thinking about moving it to the LLVM repo, because IMO it would make most sense next to llvm-exegesis).
Yep. Consolidating on something eventually would be good. It might not be this. This was mostly just something I threw together as when I was experimenting with the current Owen's annotator is significantly faster. The Exegesis annotator is pretty slow. I haven't profiled it yet, but I suspect at least some of the slowness is inherent to the design. Everything has to get emitted to textual assembly, reparsed, reassembled, and then executed. Something to fix this would be nice, but I don't think it would be trivial. Upstreaming definitely is something to look into at some point. We'll have to see where this ends up going and what ends up scaling well. |
SGTM. Let me upstream that first. |
|
I've updated the patch to fix the includes in the various places where |
This patch adds in an alternative to the existing find_accessed_addrs infrastructure that uses llvm-exegesis as a backend. We believe this will more closely match the execution environment of the benchmarking environment and should avoid some of the pitfalls of the existing memory annotation infrastructure (at the current expense of speed).