Parallelize memory annotations #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch parallelizes memory annotations in the convert_bhive_to_llvm_exegesis script, particularly to speed up annotations using the exegesis annotator. This uses the LLVM threading primitives, particularly ThreadPool
|
This is stacked on #82. |
…xeegesis' into users/boomanaiden154/parallelize-annotator
|
Closing this as the threading doesn't actually end up improving performance. I've spent a bit of time debugging, but was never able to figure it out. Using an external script for orchestration with multiple processes (python+ray) sped things up about linearly with the number of cores. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch parallelizes memory annotations in the
convert_bhive_to_llvm_exegesis script, particularly to speed up annotations using the exegesis annotator. This uses the LLVM threading primitives, particularly ThreadPool.
This fixes #56.