Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIPS: Add support for MIPS MSA SIMD. #120

Merged
merged 1 commit into from
Jan 19, 2018
Merged

MIPS: Add support for MIPS MSA SIMD. #120

merged 1 commit into from
Jan 19, 2018

Conversation

alexfru
Copy link
Contributor

@alexfru alexfru commented Jan 18, 2018

I may provide instructions on how to set up the compilers, build the tests for MIPS and run them. Let me know if/when you want this.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@alexfru
Copy link
Contributor Author

alexfru commented Jan 18, 2018

I'm an AOSP contributor (look up Alexey Frunze in e.g. art). Do I still need to do something about the CLA?

@bjacob
Copy link
Contributor

bjacob commented Jan 18, 2018

Hi Alex,

Thanks for the contribution.

Can you share a bit about your motivation for MIPS support: this is a substantial expansion of gemmlowp's set of hardware targets, and I need to understand some rationale for it. Do you have a specific use case for MIPS support or is this done 'for the beauty of it' ? (I understand this might be hard to discuss; just a yes/no answer is fine).

Regarding the CLA, you need to sign it, but it can be either individual (if you are legally the author of this work) or corporate (if acting on behalf of your employer i.e. your employer is the legal 'author' and you're just a 'contributor').

@alexfru
Copy link
Contributor Author

alexfru commented Jan 18, 2018

I'm acting on behalf of the employer (MIPS), just as with AOSP. The answer to the other question is yes (for a more elaborate answer we could probably go private). Including @glraghukishore, my direct manager.

@bjacob
Copy link
Contributor

bjacob commented Jan 18, 2018

OK, thanks for the reply.

If your employer is the copyright holder of the open-source code that you contribute, then:

  1. your employer needs to sign the Google CLA, if not already done;
  2. the PR needs to be updated to mention your employer in AUTHORS and yourself in CONTRIBUTORS.

Unless another Googler here feels otherwise, I'm going to default to saying that MIPS caring enough about this to contribute this code is a solid enough reason to take it, so that issue is cleared too. Just please note that I and other gemmlowp maintainers don't have much experience with MIPS hardware and don't have local hardware to test this code. So I have to say there are no guarantees of not regressing this code, though in practice, gemmlowp being widely used, it is possible that some test targets will exercise it on MIPS somewhere.

@googlebot
Copy link

CLAs look good, thanks!

@bjacob
Copy link
Contributor

bjacob commented Jan 19, 2018

Thanks, the patch looks perfect, well well integrated! Merging.

@bjacob bjacob merged commit c915905 into google:master Jan 19, 2018
@alexfru alexfru deleted the mips_msa branch January 19, 2018 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants