-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIPS: Add support for MIPS MSA SIMD. #120
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I'm an AOSP contributor (look up Alexey Frunze in e.g. art). Do I still need to do something about the CLA? |
Hi Alex, Thanks for the contribution. Can you share a bit about your motivation for MIPS support: this is a substantial expansion of gemmlowp's set of hardware targets, and I need to understand some rationale for it. Do you have a specific use case for MIPS support or is this done 'for the beauty of it' ? (I understand this might be hard to discuss; just a yes/no answer is fine). Regarding the CLA, you need to sign it, but it can be either individual (if you are legally the author of this work) or corporate (if acting on behalf of your employer i.e. your employer is the legal 'author' and you're just a 'contributor'). |
I'm acting on behalf of the employer (MIPS), just as with AOSP. The answer to the other question is yes (for a more elaborate answer we could probably go private). Including @glraghukishore, my direct manager. |
OK, thanks for the reply. If your employer is the copyright holder of the open-source code that you contribute, then:
Unless another Googler here feels otherwise, I'm going to default to saying that MIPS caring enough about this to contribute this code is a solid enough reason to take it, so that issue is cleared too. Just please note that I and other gemmlowp maintainers don't have much experience with MIPS hardware and don't have local hardware to test this code. So I have to say there are no guarantees of not regressing this code, though in practice, gemmlowp being widely used, it is possible that some test targets will exercise it on MIPS somewhere. |
CLAs look good, thanks! |
Thanks, the patch looks perfect, well well integrated! Merging. |
I may provide instructions on how to set up the compilers, build the tests for MIPS and run them. Let me know if/when you want this.