Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding .readthedocs.yaml file #31

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Adding .readthedocs.yaml file #31

merged 1 commit into from
Aug 2, 2022

Conversation

mohanad0mohamed
Copy link
Contributor

Fixes #26

  • Added simple .readthedocs.yaml.

@mithro
Copy link
Contributor

mithro commented Jul 26, 2022

As this adds fail_on_warning: true it'll need to wait until #35 is merged.

@mithro mithro self-requested a review July 26, 2022 02:28
mithro
mithro approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mithro
Copy link
Contributor

mithro commented Aug 2, 2022

I removed the fail_on_warning: true flag so that I can merge this pull request before we fix all the warnings.

@mithro mithro merged commit a134ccb into google:main Aug 2, 2022
@mithro mithro deleted the yaml_file branch August 2, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mithro mithro mithro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a .readthedocs.yml config file
2 participants
@mohanad0mohamed @mithro