Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

brew formula missing? #3

Closed
dwabyick opened this issue Jan 9, 2015 · 14 comments
Closed

brew formula missing? #3

dwabyick opened this issue Jan 9, 2015 · 14 comments

Comments

@dwabyick
Copy link

dwabyick commented Jan 9, 2015

I updated and upgraded my brew, and I still cannot brew install google-js-test

@dunn
Copy link

dunn commented Apr 23, 2015

The Homebrew formula still has the url as https://google-js-test.googlecode.com/files/gjstest-1.0.8.tar.bz2, which 404s now. There'll need to be a tagged release here before the formula can be updated, though.

@jacobsa
Copy link
Contributor

jacobsa commented Apr 26, 2015

@dunn: I'll be honest and say I don't know what all needs to be done to get homebrew working again. Is it just tagging a release? Are you able to carry it through to completion if I do so?

@dunn
Copy link

dunn commented Apr 27, 2015

Yeah, I can open a pull request over at the Homebrew repository.

I just noticed that the google-js-test formula was moved to the 'head-only' tap a while ago because the re2 dependency didn't have a stable release at the time. Now re2 does, so if you also have a stable release here, I can ask that google-js-test.rb be moved back into core Homebrew. If you don't have a stable release ready, then I can just update the existing 'head-only' formula to point to this repository instead of the old Google Code tarball.

@jacobsa
Copy link
Contributor

jacobsa commented Apr 27, 2015

Thanks. I've (arbitrarily) tagged v1.0 at HEAD.

@dunn
Copy link

dunn commented Apr 27, 2015

Testing the updated formula; you might need to walk me through this build error:

In file included from gjstest/internal/cpp/typed_arrays.cc:18:
/usr/local/include/v8.h:3915:36: error: 'v8::PropertyHandlerFlags' is not a class, namespace, or scoped enumeration
      PropertyHandlerFlags flags = PropertyHandlerFlags::kNone)
                                   ^
/usr/local/include/v8.h:3943:36: error: 'v8::PropertyHandlerFlags' is not a class, namespace, or scoped enumeration
      PropertyHandlerFlags flags = PropertyHandlerFlags::kNone)
                                   ^
./scripts/cc_library_make_header_deps_file.sh  base/macros base/type_traits.header_deps Makefile base/macros.h scripts/cc_library_make_header_deps_file.sh
2 errors generated.
make: *** [gjstest/internal/cpp/typed_arrays.o] Error 1
make: *** Waiting for unfinished jobs....
In file included from gjstest/internal/cpp/gjstest.cc:42:
In file included from ./gjstest/internal/cpp/typed_arrays.h:25:
/usr/local/include/v8.h:3915:36: error: 'v8::PropertyHandlerFlags' is not a class, namespace, or scoped enumeration
      PropertyHandlerFlags flags = PropertyHandlerFlags::kNone)
                                   ^
/usr/local/include/v8.h:3943:36: error: 'v8::PropertyHandlerFlags' is not a class, namespace, or scoped enumeration
      PropertyHandlerFlags flags = PropertyHandlerFlags::kNone)
                                   ^
2 errors generated.
make: *** [gjstest/internal/cpp/gjstest.o] Error 1

Happens with clang and gcc.

Full logs with config

@jacobsa
Copy link
Contributor

jacobsa commented Apr 27, 2015

Sigh, welcome to the wonderful world of being a V8 embedder. :-( Unfortunately, the V8 team regularly breaks backwards compatibility for its C++ API. The only version that will work is the one I have most recently spent the annoyingly-long amount of time necessary to make work. In this case it appears to be version 3.28.71, with the fix in a610799.

I suppose we could find an old commit in the gjstest repo that works with the version of v8 in homebrew (this is not guaranteed to exist), then tag a release there.

@dunn
Copy link

dunn commented Apr 27, 2015

Homebrew is keeping v8 up to date with Chrome stable, which looks like 4.1.0.27 right now.

The other option would be to vendor 3.28.71 for this formula. But I'm not sure I'll be able to do that right; the Homebrew install process for v8 is pretty finicky.

@jacobsa
Copy link
Contributor

jacobsa commented Apr 27, 2015

Oh wow, last time I looked homebrew's version of v8 was ancient. Then the work necessary is to overcome yet another round of incompatible v8 changes. I don't have the bandwidth for that at this moment, but will likely need to do it for Google-internal reasons at some point in the medium-term future.

@dunn
Copy link

dunn commented Apr 27, 2015

Sounds good; thanks for the help!

@jacobsa
Copy link
Contributor

jacobsa commented Apr 29, 2015

I've almost got this working at 28ebcef, but am stymied by dynamic linking issues with re2. Any help with Homebrew/legacy-homebrew#39198 would be greatly appreciated.

@jacobsa
Copy link
Contributor

jacobsa commented Jun 25, 2015

Again almost working at 4b3c9f4, but now blocked on link errors that I simply can't figure out (see Homebrew/legacy-homebrew#41091).

@pierredelisle7
Copy link

Installation via brew still seems broken:
$ brew install google-js-test
Error: No available formula for google-js-test
Searching formulae...
Searching taps...

Is there an easy workaround?

@jacobsa
Copy link
Contributor

jacobsa commented Aug 30, 2015

@pierredelisle7: This is still blocked on Homebrew/legacy-homebrew#41091, which causes the libv8 installed by homebrew to be incorrectly built. There is no easy workaround, chiefly because building v8 is a pain in the ass.

jacobsa added a commit to jacobsa/homebrew that referenced this issue Sep 1, 2015
There was a gjstest formula in the past, but it stopped building due to
v8 issues and was removed. As of the v8 upgrade in 9dae089, this can
work again.

For google/gjstest#3.
jacobsa added a commit to jacobsa/homebrew that referenced this issue Sep 1, 2015
There was a gjstest formula in the past, but it stopped building due to
v8 issues and was removed. As of the v8 upgrade in 9dae089, this can
work again.

For google/gjstest#3.
jacobsa added a commit to jacobsa/homebrew that referenced this issue Sep 1, 2015
There was a gjstest formula in the past, but it stopped building due to
v8 issues and was removed. As of the v8 upgrade in 9dae089, this can
work again.

For google/gjstest#3.
jacobsa added a commit to jacobsa/homebrew that referenced this issue Sep 1, 2015
There was a gjstest formula in the past, but it stopped building due to
v8 issues and was removed. As of the v8 upgrade in 9dae089, this can
work again.

For google/gjstest#3.
jacobsa added a commit to jacobsa/homebrew that referenced this issue Sep 2, 2015
There was a gjstest formula in the past, but it stopped building due to
v8 issues and was removed. As of the v8 upgrade in 9dae089, this can
work again.

For google/gjstest#3.
jacobsa added a commit to jacobsa/homebrew that referenced this issue Sep 2, 2015
There was a gjstest formula in the past, but it stopped building due to
v8 issues and was removed. As of the v8 upgrade in 9dae089, this can
work again.

For google/gjstest#3.
dunn pushed a commit to Homebrew/legacy-homebrew that referenced this issue Sep 3, 2015
There was a gjstest formula in the past, but it stopped building due to
v8 issues and was removed. As of the v8 upgrade in 9dae089, this can
work again.

For google/gjstest#3.

Closes #43457.

Signed-off-by: Alex Dunn <dunn.alex@gmail.com>
@jacobsa
Copy link
Contributor

jacobsa commented Sep 3, 2015

Updated the installation instructions. You should now be able to brew install gjstest.

@jacobsa jacobsa closed this as completed Sep 3, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants