Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GKE Benchmark 1.4 Controls #196

Merged
merged 18 commits into from
Oct 23, 2023
Merged

Added GKE Benchmark 1.4 Controls #196

merged 18 commits into from
Oct 23, 2023

Conversation

spawar-apex
Copy link
Contributor

  • Added Node CoS & Cluster Intranode Visibility control to the GKE Policies.

@google-cla
Copy link

google-cla bot commented Oct 19, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@mikouaj mikouaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @spawar-apex, thank you for this great contribution on intranode visibility policy!

FYI the table in a gke-policies-v2/README.md file can be generated automatically by running generate policy-docs command, i.e:

./gke-policy generate policy-docs -local-policy-dir ./gke-policies-v2 -f generated-policy-docs.md

The generated table takes policies and their metadata from a given directory. This helps to avoid human errors. For instance, I think that Container-Optimized OS policy was already in this README.md as Use Container-Optimized OS.

@spawar-apex
Copy link
Contributor Author

Hi @spawar-apex, thank you for this great contribution on intranode visibility policy!

FYI the table in a gke-policies-v2/README.md file can be generated automatically by running generate policy-docs command, i.e:

./gke-policy generate policy-docs -local-policy-dir ./gke-policies-v2 -f generated-policy-docs.md

The generated table takes policies and their metadata from a given directory. This helps to avoid human errors. For instance, I think that Container-Optimized OS policy was already in this README.md as Use Container-Optimized OS.

Thank you @mikouaj for sharing the details. I'll make necessary updates and push the PR.

Copy link
Member

@mikouaj mikouaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @spawar-apex, please do not commit the generated-policy-docs.md file. Simply copy the content of the generated file to the gke-policies-v2/README.md instead, below the
<!-- BEGIN POLICY-DOC --> statement.

@mikouaj
Copy link
Member

mikouaj commented Oct 20, 2023

I agree that the process can be unclear, I will add necessary instruction to the policy authoring guide.

@spawar-apex
Copy link
Contributor Author

I agree that the process can be unclear, I will add necessary instruction to the policy authoring guide.

oh.ok. Sure. Thanks @mikouaj .
Let me unversion generated-policy-docs.md and add the contents to the README.md and push the PR again.

Copy link
Member

@mikouaj mikouaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @spawar-apex, thank you for this contribution!

@mikouaj mikouaj merged commit 7a5cfb5 into google:main Oct 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants