Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving SRAM docs from gf180mcu-pdk #5

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Moving SRAM docs from gf180mcu-pdk #5

merged 1 commit into from
Aug 2, 2022

Conversation

mohanad0mohamed
Copy link
Contributor

@mohanad0mohamed mohanad0mohamed commented Jul 25, 2022

  • Moved all documentations in docs directory.

  • Made symbolic link for it in gf180mcu-pdk

  • Built locally with no errors

Fixes google/gf180mcu-pdk#11

@mithro
Copy link
Contributor

mithro commented Jul 28, 2022

I have reworked this pull request slightly. I move the specs to a specs directory under each cell. See the commit at 894afa5

@mithro
Copy link
Contributor

mithro commented Jul 28, 2022

@mohanad0mohamed - I have updated this pull request for you.

@mohanad0mohamed
Copy link
Contributor Author

Thanks @mithro. I was going to do the same but I didn't know that I can put directories inside each cell.
I thought this shouldn't happen so I made them in docs directory.

@mohanad0mohamed
Copy link
Contributor Author

mohanad0mohamed commented Jul 28, 2022

I have moved code_of_conduct.rst and contributing.rst outside docs not to produce warnings. Also edited README.rst to change 180um to 180nm.

I think this edit should happen also in mcu7t5v0 and mcu9t5v0 not to produce warnings in building the docs.

@mithro
Copy link
Contributor

mithro commented Aug 2, 2022

I have moved code_of_conduct.rst and contributing.rst outside docs not to produce warnings. Also edited README.rst to change 180um to 180nm.

Two comments;

  • Please keep pull requests to a single item.
  • We should fix the warnings from these docs, not remove the docs all together.

@mithro mithro reopened this Aug 2, 2022
@mithro
Copy link
Contributor

mithro commented Aug 2, 2022

@mohanad0mohamed - I have removed the non-moving SRAM docs changes from this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the SRAM documentation into the SRAM IP repository
2 participants