Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the top level spice file names under models #5

Open
mithro opened this issue Jul 22, 2022 · 3 comments
Open

Improve the top level spice file names under models #5

mithro opened this issue Jul 22, 2022 · 3 comments
Assignees

Comments

@mithro
Copy link
Contributor

mithro commented Jul 22, 2022

The names of the top level spice files are currently;

./models
./models/ngspice
./models/ngspice/design.ngspice
./models/ngspice/sm141064.ngspice
./models/ngspice/smbb000149.ngspice
./models/xyce
./models/xyce/design.xyce
./models/xyce/sm141064.xyce
./models/xyce/smbb000149.xyce

The names design / sm141064 / smbb000149 don't really have useful meanings. I believe that @mkkassem has better names that should be used instead.

@mithro
Copy link
Contributor Author

mithro commented Jul 22, 2022

I think @mkkassem was suggesting something like this?

  • design --> gf180mcu.global_parameters
  • sm141064 --> gf180mcu.common
  • smb000149 --> gf180mcu.highvoltage

@mkkassem - Can you document what these files should be called and then assign the issue to the right person to fix?

@atorkmabrains
Copy link
Collaborator

@mithro I agree with the suggestion above. If @mkkassem approves, we could move forward.

@mohanad0mohamed
Copy link
Contributor

@mithro Should I start to fix the issue with @mkkassem suggestions?

atorkmabrains added a commit to christoph-weiser/globalfoundries-pdk-libs-gf180mcu_fd_pr that referenced this issue Dec 18, 2022
proppy pushed a commit to proppy/globalfoundries-pdk-libs-gf180mcu_fd_pr that referenced this issue Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Ready
Development

No branches or pull requests

4 participants