Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider using a test framework #79

Closed
proppy opened this issue Nov 29, 2022 · 8 comments
Closed

consider using a test framework #79

proppy opened this issue Nov 29, 2022 · 8 comments

Comments

@proppy
Copy link
Member

proppy commented Nov 29, 2022

Expected Behavior

Tests should be using python testing best practices.

One popular framework is pytest: https://docs.pytest.org/en/7.2.x/ as it comes with:

Actual Behavior

Tests uses monolytics python scripts with manual exit() invocation, see https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/blob/main/rules/klayout/drc/testing/run_regression.py#L243

proppy pushed a commit to proppy/globalfoundries-pdk-libs-gf180mcu_fd_pr that referenced this issue Feb 6, 2023
@FaragElsayed2
Copy link
Collaborator

@atorkmabrains Did we hit this target in the new testing environment we have in PV repo ?

@atorkmabrains
Copy link
Collaborator

@FaragElsayed2 I don't believe so. I believe we still use the normal regression flow for PV. I recommend that we open another issue on PV repo and close this one.

@FaragElsayed2
Copy link
Collaborator

@atorkmabrains Should I do that or wait for @proppy to move it ?

@atorkmabrains
Copy link
Collaborator

@FaragElsayed2 Please open the other issue on the PV repo and we I'll close that one. Please make sure to link the new issue to this issue.

@FaragElsayed2
Copy link
Collaborator

@atorkmabrains Done

@atorkmabrains
Copy link
Collaborator

@FaragElsayed2 Could you please link it here?

@FaragElsayed2
Copy link
Collaborator

@atorkmabrains
Copy link
Collaborator

@proppy I'm closing this issue as we moved it to PV repo as @FaragElsayed2 has highlighted above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants