Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve transistor definitions in xschem lvs export #102

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Improve transistor definitions in xschem lvs export #102

merged 2 commits into from
Feb 7, 2023

Conversation

StefanSchippers
Copy link
Contributor

@StefanSchippers StefanSchippers commented Feb 6, 2023

  • strip unusted parameters on LVS export
  • avoids X prefix
  • fix substrate pin of vnpn_10x10.sym (was named "B" instead of "S")

(Still to be decided if we want to make similar changes for LVS on other devices (moscap and others)

Fixes #101

@proppy
Copy link
Member

proppy commented Feb 7, 2023

/cc @atorkmabrains FYI

@@ -33,7 +33,7 @@ L 4 0 -10 20 -30 {}
B 5 17.5 -32.5 22.5 -27.5 {name=C dir=inout pinnumber=3}
B 5 -22.5 -2.5 -17.5 2.5 {name=B dir=in pinnumber=1}
B 5 17.5 27.5 22.5 32.5 {name=E dir=inout pinnumber=2}
B 5 17.5 -2.5 22.5 2.5 {name=B dir=in pinnumber=1}
B 5 17.5 -2.5 22.5 2.5 {name=S dir=in pinnumber=1}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StefanSchippers is this change related?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latter one fixes a wrong pin in the vnpn transistor. It has the substrate pin incorrectly named as the base (B) pin, making base and substrate shorted.
The fix renamed the substrate pin from 'B' to 'S'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense, updating the PR so that it makes it clearer that it fixes both before merging.

Copy link
Member

@proppy proppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit.

@proppy proppy changed the title add lvs_format attribute to all nfet and pfet transistors for LVS Improve transistor definitions in lvs deck Feb 7, 2023
@atorkmabrains
Copy link
Collaborator

@StefanSchippers Could you please make sure to add a similar PR on: https://github.com/efabless/globalfoundries-pdk-libs-gf180mcu_fd_pr

@proppy proppy changed the title Improve transistor definitions in lvs deck Improve transistor definitions in xschem lvs export Feb 7, 2023
@proppy
Copy link
Member

proppy commented Feb 7, 2023

@StefanSchippers Could you please make sure to add a similar PR on: https://github.com/efabless/globalfoundries-pdk-libs-gf180mcu_fd_pr

Done here: efabless#23

@proppy
Copy link
Member

proppy commented Feb 7, 2023

@StefanSchippers can lvs_format also be used to other component used only by simulation from the LVS netlist? (C blocks for lab pin, spice model, etc)

@StefanSchippers
Copy link
Contributor Author

If you add an lvs_format this takes precedence over format when doing LVS netlists.
This can be used to exclude simulation-only devices from LVS netlist, like for example in:
lvs_format="* @name @pinlist @value"
Notice the '*' at the beginning. This will add just a commented line in the netlist.
Just make sure lvs_format is not empty, because in this case the xschem netlister will revert to format attribute. Even a single space will be ok, like in:
lvs_format=" "

@proppy
Copy link
Member

proppy commented Feb 7, 2023

Just make sure lvs_format is not empty, because in this case the xschem netlister will revert to format attribute. Even a single space will be ok, like in:
lvs_format=" "

Yes, I went for lvs_format="*" :) Thanks for the tip!

@proppy proppy merged commit 11770e5 into google:main Feb 7, 2023
proppy pushed a commit to proppy/globalfoundries-pdk-libs-gf180mcu_fd_pr that referenced this pull request Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lvs script should be able to import xschem netlist
3 participants