Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix xschemrc #113

Merged
merged 1 commit into from
Apr 29, 2023
Merged

fix xschemrc #113

merged 1 commit into from
Apr 29, 2023

Conversation

curtisma
Copy link
Contributor

@curtisma curtisma commented Apr 29, 2023

Fixes #112

It also makes it more similar to the SKY130 xschemrc.

  • Tests pass
    See "Testing" section below
  • Appropriate changes to README are included in PR
    No changes to the README are required.

Testing

  • the default schematic opens up when starting xschem without a schematic path provided
  • test_nfet_0.v3.sch is successful:
    image

@google-cla
Copy link

google-cla bot commented Apr 29, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@curtisma
Copy link
Contributor Author

Will someone please rerun the CLA check?
I've now signed it.

@curtisma
Copy link
Contributor Author

curtisma commented Apr 29, 2023

@proppy and @mithro, can you guys take a look and merge if this fix for the xschemrc is acceptable?

@curtisma
Copy link
Contributor Author

curtisma commented Apr 29, 2023

I feel like there is a lot of repo layers for this to propagate through for it to end up fixing the original iic-osic-tools Issue #9

  • Merge this one
  • The gf180mcu PDK repo this is used in
    Why aren't each of the libraries just included in this repo. It seems like there will need to be a bump in this repo to get the update. Is this manual?
  • openpdks
  • iic-osic-tools

@curtisma
Copy link
Contributor Author

so I just saw #112 which helps complement the issues fixed by this PR.

@curtisma
Copy link
Contributor Author

cc: @atorkmabrains @StefanSchippers
Let me know if you have any comments on these fixes

@curtisma
Copy link
Contributor Author

@QuantamHD, you seem to have merged the last PR that was merged, can you take a look?

cells/xschem/xschemrc Show resolved Hide resolved
cells/xschem/xschemrc Show resolved Hide resolved
@QuantamHD
Copy link
Collaborator

Still seems like you're missing the CLA check. Other than a few minor questions. LGTM

@StefanSchippers
Copy link
Contributor

StefanSchippers commented Apr 29, 2023

Google says I have (already) signed the CLA. I have signed again. hope its ok
1

@curtisma
Copy link
Contributor Author

@QuantamHD
Can any of the 29 previous PRs be merged? A lot of them seem ready.

@QuantamHD
Copy link
Collaborator

I'll try to make my way through them. I'll merge this once the DRC passes.

@QuantamHD
Copy link
Collaborator

Are there any high priority PRs you need. A lot of them have merge conflicts or CI failures. I want to prioritize what's most important to you.

@QuantamHD QuantamHD merged commit 7a47d78 into google:main Apr 29, 2023
11 checks passed
@curtisma
Copy link
Contributor Author

Thanks for merging!
@QuantamHD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix gf180mcuC xschemrc
3 participants