-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix xschemrc #113
fix xschemrc #113
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Will someone please rerun the CLA check? |
I feel like there is a lot of repo layers for this to propagate through for it to end up fixing the original iic-osic-tools Issue #9
|
so I just saw #112 which helps complement the issues fixed by this PR. |
cc: @atorkmabrains @StefanSchippers |
@QuantamHD, you seem to have merged the last PR that was merged, can you take a look? |
Still seems like you're missing the CLA check. Other than a few minor questions. LGTM |
@QuantamHD |
I'll try to make my way through them. I'll merge this once the DRC passes. |
Are there any high priority PRs you need. A lot of them have merge conflicts or CI failures. I want to prioritize what's most important to you. |
Thanks for merging! |
Fixes #112
It also makes it more similar to the SKY130 xschemrc.
See "Testing" section below
No changes to the README are required.
Testing