Fix broken standard cell schematic images #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The title of this pull request needs to be improved. |
mithro
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
This pull request seem to be a generally good move in the right direction, so I'm going to go ahead and merge it.
However, a review of this pull request highlighted the following issues with schematics;
- Figure out what is going on with the fill schematic rendering #12
- Figure out how to fix the flip flop schematic rendering #11
- Figure out how to fix the buffers schematic rendering #10
Fixing these might be hard, so let's work on easier things first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes google/gf180mcu-pdk#17
Fixes google/gf180mcu-pdk#20
Fixed broken schematics
Reformatted them as
svginstead ofpngBuilt locally with no warnings.
Checked empty images if they 0 bytes.