Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIx schematics images #12

Merged
merged 1 commit into from
Aug 12, 2022
Merged

FIx schematics images #12

merged 1 commit into from
Aug 12, 2022

Conversation

mohanad0mohamed
Copy link
Contributor

@mohanad0mohamed mohanad0mohamed commented Aug 8, 2022 •
edited
Loading

Fixes google/gf180mcu-pdk#17
Fixes google/gf180mcu-pdk#20

  • Fixed broken schematics

  • Reformatted them as svg instead of png

  • Built locally with no warnings.

  • Checked empty images if they 0 bytes.

@mohanad0mohamed mohanad0mohamed mentioned this pull request Aug 8, 2022
Open
@mithro mithro changed the title fix_schematics FIx schematics images Aug 12, 2022
mithro
mithro approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mithro mithro merged commit f9d9bc0 into google:main Aug 12, 2022
@mithro mithro deleted the fix_schematics branch August 12, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mithro mithro mithro approved these changes

@atorkmabrains atorkmabrains Awaiting requested review from atorkmabrains

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix all the warnings produced when building sphinx documentation Broken zero size schematic images
2 participants
@mohanad0mohamed @mithro