Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename METAL1 to Metal1 in all cells lef to match the techlef #15

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Rename METAL1 to Metal1 in all cells lef to match the techlef #15

merged 1 commit into from
Sep 7, 2022

Conversation

kareefardi
Copy link
Contributor

@kareefardi kareefardi commented Sep 1, 2022 •
edited by mithro
Loading

Fixes #14

@google-cla

This comment was marked as outdated.

Sign in to view
RTimothyEdwards
RTimothyEdwards approved these changes Sep 1, 2022
View reviewed changes
Copy link
Collaborator

@RTimothyEdwards RTimothyEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments I made for the similar pull request on mcu7t5v0. Please merge ASAP.

@mithro mithro changed the title rename METAL1 to Metal1 in all cells lef to match the techlef Rename METAL1 to Metal1 in all cells lef to match the techlef Sep 4, 2022
@mithro
Copy link
Contributor

mithro commented Sep 4, 2022

@atorkmabrains - Can you review and confirm this is the right direction? (IE Should the lef be updated or the techlef be changed instead?)

@mithro mithro mentioned this pull request Sep 5, 2022
Closed
@proppy proppy mentioned this pull request Sep 7, 2022
Closed
@QuantamHD QuantamHD merged commit f4bd79c into google:main Sep 7, 2022
atorkmabrains
atorkmabrains reviewed Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@atorkmabrains atorkmabrains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change matches request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atorkmabrains atorkmabrains atorkmabrains left review comments

@RTimothyEdwards RTimothyEdwards RTimothyEdwards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Miss-match in metal layer names between cells lef and tech lef
5 participants
@kareefardi @mithro @RTimothyEdwards @atorkmabrains @QuantamHD