Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port stack tracing to Windows #151

Closed
wants to merge 3 commits into from

Conversation

andyleejordan
Copy link
Contributor

@andyleejordan andyleejordan commented Jan 4, 2017

This set of patches implements the stack trace, symbolizer, and demangler for Windows, and their unit tests. It utilizes the Windows debugging APIs in "Dbghelp.h". I'd like this to start being reviewed, but feel it probably needs some more unit tests and definitely needs to be integration tested. I'll also clean up the commits before it's applied. This is a work in progress, with more up-to-date work on my test branch. I mostly need to fix how the stack trace reporting is called, as using the signal handler does not seem to result in the desired behavior on Windows.

/cc @hausdorff

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@andyleejordan
Copy link
Contributor Author

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@andyleejordan andyleejordan deleted the windows-stacktrace branch March 4, 2017 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants