Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for msvs 2015 RC #30

Closed
wants to merge 2 commits into from

Conversation

KjellSchubert
Copy link

glog won't compile without these changes for msvs 2015 RC. I found the need for deleting the move ctor odd, especially since the libglog_static project compiled without it, only the libglog project needed it (apparently C++11 features cannot be disabled in msvs, see http://stackoverflow.com/questions/23386472/disable-c11-features-in-vs2013)

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@KjellSchubert
Copy link
Author

I signed it

On Tuesday, May 19, 2015, googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project, in which case you'll need to
sign a Contributor License Agreement (CLA).

[image: 📝] Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.


Reply to this email directly or view it on GitHub
#30 (comment).

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@ukai ukai mentioned this pull request Aug 6, 2015
@sergiud
Copy link
Collaborator

sergiud commented Oct 31, 2019

Changes seems to be obsolete. Please reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants