Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automake: relax GNU standard directory style #408

Merged
merged 2 commits into from
Dec 18, 2018
Merged

automake: relax GNU standard directory style #408

merged 2 commits into from
Dec 18, 2018

Conversation

zhenhuaw-me
Copy link
Contributor

GNU standard assumes README under root dir, while PR #403
didn't fix the building issue exactually.
https://www.gnu.org/software/automake/manual/html_node/List-of-Automake-options.html

@zhenhuaw-me
automake: relax GNU standard directory style
1231a37 
GNU standard assumes `README` under root dir, while PR #403
didn't fix the building issue exactually.
https://www.gnu.org/software/automake/manual/html_node/List-of-Automake-options.html
@zhenhuaw-me
update all README naming
da37a6c 
Now, we can build.
@zhenhuaw-me
Copy link
Contributor Author

zhenhuaw-me commented Dec 18, 2018 •
edited
Loading

master build still broken, see #402 and #407.

With this we can build...

@zhenhuaw-me
Copy link
Contributor Author

Btw, what about to remove auto-generated files from repository?
For me, the git status returns:

On branch fix/build/readme
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

        modified:   ltmain.sh
        modified:   m4/libtool.m4
        modified:   m4/ltoptions.m4
        modified:   m4/ltversion.m4
        modified:   src/config.h.in

@zhenhuaw-me zhenhuaw-me mentioned this pull request Dec 18, 2018
Closed
@sergiud sergiud added the LGTM label Dec 18, 2018
@sergiud
Copy link
Collaborator

sergiud commented Dec 18, 2018

@jackwish Please create a separate PR which removes these temporaries.

@sergiud sergiud merged commit 6deff5a into google:master Dec 18, 2018
@zhenhuaw-me zhenhuaw-me mentioned this pull request Dec 19, 2018
Merged
@zhenhuaw-me
Copy link
Contributor Author

@jackwish Please create a separate PR which removes these temporaries.

@sergiud check #410 please.

durswd pushed a commit to durswd/glog that referenced this pull request Sep 2, 2019
@sergiud
Merge pull request google#408 from jackwish/fix/build/readme
d5f57a2 
automake: relax GNU standard directory style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhenhuaw-me @sergiud @googlebot