Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepend the year to each glog line (#516) #530

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Prepend the year to each glog line (#516) #530

merged 2 commits into from
Mar 25, 2020

Conversation

aesophor
Copy link
Contributor

@aesophor aesophor commented Mar 8, 2020 •
edited
Loading

This PR fixes issue #516 by prepending the year to each glog line.

Previous format of each line in a log file:
[IWEF]mmdd hh:mm:ss.uuuuuu threadid file:line] msg

New format:
[IWEF]yyyymmdd hh:mm:ss.uuuuuu threadid file:line] msg


This is what a log file will actually look like:

Log file created at: 2020/03/08 23:47:32
Running on machine: adagio
Log line format: [IWEF]yyyymmdd hh:mm:ss.uuuuuu threadid file:line] msg
I20200308 23:47:32.089828 400441 config.cc:27] Loading user configuration: /home/aesophor/.config/wmderland/config
I20200309 07:41:46.769781 400441 config.cc:27] Loading user configuration: /home/aesophor/.config/wmderland/config

@aesophor
Prepend the year to each glog line (google#516)
ba9c5f4 
This PR fixes issue google#516 by prepending the year to each glog line.

Previous format of each line in a log file:
[IWEF]mmdd hh:mm:ss.uuuuuu threadid file:line] msg

New format:
[IWEF]yyyymmdd hh:mm:ss.uuuuuu threadid file:line] msg
@aesophor
Fix logging_unittest for PR google#530
f066249 
Since the format of each glog line has been changed,
the logging_unittest must also be updated.
@aesophor aesophor mentioned this pull request Mar 8, 2020
Closed
@vctang
Copy link

vctang commented Mar 11, 2020

Thank you for adding this!!

@sergiud sergiud merged commit 5b4fb63 into google:master Mar 25, 2020
@aesophor aesophor deleted the glog-append-year branch March 25, 2020 11:10
@kgreenek kgreenek mentioned this pull request May 11, 2020
Closed
@sergiud sergiud added this to the 0.5 milestone Mar 30, 2021
@sergiud sergiud mentioned this pull request May 6, 2021
Merged
davidflanagan pushed a commit to davidflanagan/glog that referenced this pull request Jan 25, 2022
Add the year to the glog header
418ac45 
See google/glog#530
@davidflanagan davidflanagan mentioned this pull request Jan 25, 2022
Open
@wanghenshui wanghenshui mentioned this pull request Jan 16, 2024
Closed
@gnoack gnoack mentioned this pull request Jun 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aesophor @vctang @sergiud @googlebot