Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more fleet-wide settings in the config file #122

Closed
burgerdev opened this issue Mar 23, 2022 · 5 comments
Closed

Support more fleet-wide settings in the config file #122

burgerdev opened this issue Mar 23, 2022 · 5 comments
Assignees
@vvidic

Comments

@burgerdev
Copy link
Collaborator

It would be convenient if we could set a couple of options that are usually constant in a given deployment environment with the config file. That would allow sharing a glome-login binary between environments, and customizing each environment with the config file only. Things that I can think of:

  • hostid-type (hostid would still be obtained from gethostname(2))
  • syslog config
  • timeouts and sleeps
  • minimum tag length
@vvidic
Copy link
Collaborator

vvidic commented Mar 24, 2022

Yes, I was planning to add long command line options and also make them available from the config file.

@vvidic vvidic self-assigned this Jul 5, 2022
@l9i
Copy link
Collaborator

l9i commented Mar 9, 2023

@vvidic is there anything left to do here given 3eca8ccf?

@burgerdev
Copy link
Collaborator Author

I would really like to see hostid-type support.

@vvidic
Copy link
Collaborator

vvidic commented Mar 11, 2023

Yes, most options should be available in the config now now. So, let me try to add that minimum tag length and host id type.

vvidic pushed a commit to vvidic/glome that referenced this issue Mar 12, 2023
Add config option for minimum tag length google#122
61fb907 
Required tag length can only be increased from the
default value up to maximum tag length.
vvidic pushed a commit to vvidic/glome that referenced this issue Mar 12, 2023
Add config option for minimum tag length google#122
69fa596 
Required tag length can only be increased from the
default value up to maximum tag length.
vvidic pushed a commit to vvidic/glome that referenced this issue Mar 13, 2023
Add config option for minimum tag length google#122
d859fbb 
Required tag length can only be increased from the
default value up to maximum tag length.
vvidic pushed a commit to vvidic/glome that referenced this issue Mar 14, 2023
Add config option for minimum authcode length google#122
86a0f5f 
Required length can only be increased from the default value up to
maximum authcode length.
vvidic pushed a commit to vvidic/glome that referenced this issue Mar 21, 2023
Add config option for minimum authcode length google#122
29101b8 
Required length can only be increased from the default value up to
maximum authcode length.
vvidic pushed a commit to vvidic/glome that referenced this issue Mar 21, 2023
Add config option for minimum authcode length google#122
092c835 
Required length can only be increased from the default value up to
maximum authcode length.
pkern added a commit that referenced this issue Mar 24, 2023
@pkern
Merge pull request #153 from vvidic/min-tag-length
c5a8855 
Add config option for minimum authcode length #122
vvidic pushed a commit to vvidic/glome that referenced this issue Mar 30, 2023
Add config option for host-id type google#122
611495f
pkern added a commit that referenced this issue Apr 3, 2023
@pkern
Merge pull request #159 from vvidic/host-id-type
85b44df 
Add config option for host-id type #122
@vvidic
Copy link
Collaborator

vvidic commented Apr 3, 2023

I think all the mentioned options are added now, so closing this issue!

@vvidic vvidic closed this as completed Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vvidic vvidic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@burgerdev @l9i @vvidic