Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glome-cli demo outputs spurious errors when using even-sized key names #35

Closed
delroth opened this issue Aug 5, 2020 · 0 comments
Closed

Comments

@delroth
Copy link
Contributor

delroth commented Aug 5, 2020

The glome-cli demo conveniently uses Alice and Bob, respectively 5 and 3 characters. Replacing Alice with test ends up showing some spurious errors due to trying to parse test as a hex key:

$ glome-cli test
ERROR while parsing byte 0 ('te') as hex
1f8b8245ddbe65db2e593683fbc4596d0859cbdd2885a20708478880c57c8e4e

Things still work, but it's confusing.

burgerdev added a commit that referenced this issue Aug 26, 2020
This PR reworks the invocation of the `glome` utility to make it
unambiguous in its arguments and overall safer to use correctly.

* private key and peer key are now always expected to be files
* arguments are passed as flags so that they cannot be passed in the
wrong order accidentally
* messages (which may have sensitive content) are passed via `stdin` to
reduce possibility of leaks
* the code is restructured to separate `main` concerns from the
functionality

fixes #35
burgerdev added a commit that referenced this issue Sep 16, 2020
This PR reworks the invocation of the `glome` utility to make it
unambiguous in its arguments and overall safer to use correctly.

* private key and peer key are now always expected to be files
* arguments are passed as flags so that they cannot be passed in the
wrong order accidentally
* messages (which may have sensitive content) are passed via `stdin` to
reduce possibility of leaks
* the code is restructured to separate `main` concerns from the
functionality

fixes #35
burgerdev added a commit that referenced this issue Sep 18, 2020
This PR reworks the invocation of the `glome` utility to make it
unambiguous in its arguments and overall safer to use correctly.

* private key and peer key are now always expected to be files
* arguments are passed as flags so that they cannot be passed in the
wrong order accidentally
* messages (which may have sensitive content) are passed via `stdin` to
reduce possibility of leaks
* the code is restructured to separate `main` concerns from the
functionality

fixes #35
burgerdev added a commit that referenced this issue Sep 18, 2020
This PR reworks the invocation of the `glome` utility to make it
unambiguous in its arguments and overall safer to use correctly.

* private key and peer key are now always expected to be files
* arguments are passed as flags so that they cannot be passed in the
wrong order accidentally
* messages (which may have sensitive content) are passed via `stdin` to
reduce possibility of leaks
* the code is restructured to separate `main` concerns from the
functionality

fixes #35
burgerdev added a commit that referenced this issue Sep 18, 2020
This PR reworks the invocation of the `glome` utility to make it
unambiguous in its arguments and overall safer to use correctly.

* private key and peer key are now always expected to be files
* arguments are passed as flags so that they cannot be passed in the
wrong order accidentally
* messages (which may have sensitive content) are passed via `stdin` to
reduce possibility of leaks
* the code is restructured to separate `main` concerns from the
functionality

fixes #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant