New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement for cache apis #103

Merged

timburks merged 1 commit into google:master from andrewshan:master

Jan 11, 2019

Contributor

andrewshan commented Dec 14, 2018

fixed for #99

when cache is disabled, the result should not be added into cache
add full unit test for the 4 apis


          improvement for filecache apis

8efd690

1. when cache disabled, the result should  not be added into cache
2. add test for the 4 apis

timburks self-requested a review

January 11, 2019 05:19

timburks approved these changes

View reviewed changes

Contributor

timburks commented Jan 11, 2019

Thanks for adding this!

timburks merged commit 39d76df into google:master

timburks mentioned this pull request

no methods to clear or disable the fileCache and infoCache #99

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment