Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module name and support goimports local prefix #259

Merged
merged 4 commits into from
Sep 30, 2021

Conversation

zchee
Copy link
Contributor

@zchee zchee commented Sep 26, 2021

Fix module name to github.com/google/gnostic, and support goimports local prefix.

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2021
@zchee
Copy link
Contributor Author

zchee commented Sep 26, 2021

/cc @timburks

$ goimports -w -local github.com/google/gnostic $(find . -type f -name '*.go' -not -iwholename '*vendor*' -not -name '*.pb.go')

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
Copy link
Contributor

@timburks timburks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zchee Looks great! Thank you very much!

@brycefisher
Copy link

Sadly, this change has broken my go install .... I think this change is actually a breaking change, right? Since the name of the package is different, you cannot simply rollforward. So, this should be version v0.6.0 not v0.5.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants