Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnoi_cert missing arguments such as min_key_size, country, organization etc #84

Closed
Reshad-Rahman opened this issue Oct 7, 2019 · 1 comment
Closed

gnoi_cert missing arguments such as min_key_size, country, organization etc #84

Reshad-Rahman opened this issue Oct 7, 2019 · 1 comment
Assignees
@Reshad-Rahman

Comments

@Reshad-Rahman
Copy link
Contributor

The minimum key size is hard-coded at 128
https://github.com/google/gnxi/blob/master/gnoi/cert/client.go#L50

Minimum key size should be added as a parameter to https://github.com/google/gnxi/blob/master/gnoi_cert/gnoi_cert.go#L38
@Reshad-Rahman Reshad-Rahman changed the title gnoi_cert does not have a min_key_size argument gnoi_cert missing arguments such as min_key_size, country, organization etc Oct 8, 2019
@Reshad-Rahman
Copy link
Contributor Author

Same issue for country, organization, state/province etc

@Reshad-Rahman Reshad-Rahman mentioned this issue Oct 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Reshad-Rahman Reshad-Rahman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Reshad-Rahman @samribeiro