Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtimevar/runtimeconfigurator: add RPC replay tests #16

Closed
zombiezen opened this issue May 24, 2018 · 1 comment
Closed

runtimevar/runtimeconfigurator: add RPC replay tests #16

zombiezen opened this issue May 24, 2018 · 1 comment
Assignees
@cflewis
Labels
code health Code health task, either refactoring or testing
Milestone
Sprint 12

Comments

@zombiezen
Copy link
Contributor

There are existing tests in this package, they should be converted to use RPC replay. RPC replay already exists in the Go Cloud Client libraries.
@zombiezen zombiezen added this to the Sprint 12 milestone May 24, 2018
@cflewis cflewis self-assigned this May 24, 2018
@cflewis cflewis added in progress This is being actively worked on code health Code health task, either refactoring or testing labels May 25, 2018
This was referenced May 31, 2018
Closed
Merged
@cflewis
Copy link
Contributor

cflewis commented Jun 5, 2018 •
edited

This is at risk of slipping to Sprint 13 due to #65 appearing during the sprint, and being more involved than it previously appeared.

@cflewis cflewis added at risk blocked Blocked on a different issue and removed blocked Blocked on a different issue labels Jun 5, 2018
@cflewis cflewis mentioned this issue Jun 11, 2018
Merged
cflewis pushed a commit that referenced this issue Jun 13, 2018
runtimeconfig: Complete adding RPC replay tests (#84)
3aabd14 
This PR finishes adding tests for variable watching.

It removes a test for checking handling about what happens when a variable is deleted, it requires a lot of calls to the external service, and gets us into thorny flakiness issues that we tried to avoid in paramstore by having less comprehensive tests to minimize flake risk.

I actually don't understand the deleted variable code anyway and want to remove it (there's no corresponding behavior in paramstore). I'll send a follow up PR to make that code go away.

Fixes #16
@cflewis cflewis removed the in progress This is being actively worked on label Jun 15, 2018
@cflewis cflewis removed the in progress This is being actively worked on label Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cflewis cflewis

Labels
code health Code health task, either refactoring or testing
Projects
None yet
Milestone
Sprint 12
Development

No branches or pull requests
2 participants
@cflewis @zombiezen