Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtimevar/awsparamstore: implement pagination in describeParameter{,V2} #3135

Merged
merged 1 commit into from
May 26, 2022

Conversation

betaprior
Copy link
Contributor

With more than 10 entries in the SSM parameter store, runtimevar failed
to load keys unless they happened to be among the first 10 entries due
to pagination not being implemented in the AWS describeParameters API
call. This change implements the pagination. Fixes #3134.

With more than 10 entries in the SSM parameter store, runtimevar failed
to load keys unless they happened to be among the first 10 entries due
to pagination not being implemented in the AWS describeParameters API
call. This change implements the pagination.
@google-cla
Copy link

google-cla bot commented May 25, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #3135 (e9456d1) into master (05dfa16) will increase coverage by 0.06%.
The diff coverage is 78.37%.

@@            Coverage Diff             @@
##           master    #3135      +/-   ##
==========================================
+ Coverage   72.39%   72.46%   +0.06%     
==========================================
  Files         112      112              
  Lines       14266    14286      +20     
==========================================
+ Hits        10328    10352      +24     
+ Misses       3226     3219       -7     
- Partials      712      715       +3     
Impacted Files Coverage Δ
runtimevar/awsparamstore/awsparamstore.go 85.90% <78.37%> (+0.40%) ⬆️
blob/s3blob/s3blob.go 89.84% <0.00%> (-0.28%) ⬇️
server/health/sqlhealth/sqlhealth.go 80.95% <0.00%> (+19.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05dfa16...e9456d1. Read the comment docs.

@vangent
Copy link
Contributor

vangent commented May 26, 2022

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants