Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server/requestlog: make responseStats implement http.Flusher #3275

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

vangent
Copy link
Contributor

@vangent vangent commented Jul 19, 2023

Fixes #3254.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #3275 (bd49e02) into master (8cab06e) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3275      +/-   ##
==========================================
- Coverage   77.54%   77.49%   -0.06%     
==========================================
  Files         104      104              
  Lines       13718    13721       +3     
==========================================
- Hits        10638    10633       -5     
- Misses       2343     2350       +7     
- Partials      737      738       +1     
Impacted Files Coverage Δ
server/requestlog/requestlog.go 72.52% <0.00%> (-2.48%) ⬇️

... and 2 files with indirect coverage changes

@vangent vangent merged commit a1d9f42 into google:master Jul 19, 2023
6 checks passed
@vangent vangent deleted the svr2 branch July 19, 2023 20:06
ybourgery pushed a commit to Simprints/go-cloud that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

server/requestlog: support assert http.ResponseWriter to http.Flusher
1 participant