Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob/fileblob: Add an option to avoid using os.TempDir for temp files #3295

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

vangent
Copy link
Contributor

@vangent vangent commented Aug 2, 2023

Fixes #3294.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #3295 (2b57fbf) into master (37e3cd7) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3295      +/-   ##
==========================================
- Coverage   77.47%   77.46%   -0.02%     
==========================================
  Files         104      104              
  Lines       13916    13921       +5     
==========================================
+ Hits        10782    10784       +2     
- Misses       2375     2377       +2     
- Partials      759      760       +1     
Files Changed Coverage Δ
blob/fileblob/fileblob.go 82.28% <100.00%> (+0.19%) ⬆️

... and 1 file with indirect coverage changes

@vangent vangent merged commit 9b62f46 into google:master Aug 2, 2023
6 checks passed
@vangent vangent deleted the tmp branch August 2, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fileblob: os.Rename does not work between different mount points
1 participant