-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pubsub/rabbitpubsub: add query string set the qos prefetch count #3431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vangent
requested changes
May 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3431 +/- ##
==========================================
+ Coverage 73.21% 73.26% +0.04%
==========================================
Files 113 113
Lines 14873 14897 +24
==========================================
+ Hits 10890 10914 +24
+ Misses 3211 3207 -4
- Partials 772 776 +4 ☔ View full report in Codecov by Sentry. |
vangent
requested changes
May 27, 2024
vangent
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3430
Since we usually want to set the prefetch count, I simplify the rabbit url to support a single query string
we can use
rabbit://myqueue
(continues backward compatible) or the new onerabbit://myqueue?prefetch_count=<prefetch-count-value>
I tested locally using a rabbitmq docker image and it seems to work properly.