Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to set page size for tags list and catalog calls #1102

Merged
merged 1 commit into from
Aug 11, 2021
Merged

feat: ability to set page size for tags list and catalog calls #1102

merged 1 commit into from
Aug 11, 2021

Conversation

alexey-igrychev
Copy link
Contributor

I recently found that the GitHub Container Registry doesn't support pagination, so I'm limited to 1000 tags when using the library (rel https://github.community/t/pagination-when-listing-image-tags-does-not-work/194586).

I've added an option that allows disabling the default limit of 1000 tags when requesting image tags.

@alexey-igrychev alexey-igrychev changed the title feat: ability to list tags without request tags limit feat: ability to set page size for tags list and catalog calls Aug 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2021

Codecov Report

Merging #1102 (ae8071b) into main (54c3445) will decrease coverage by 0.02%.
The diff coverage is 57.14%.

❗ Current head ae8071b differs from pull request most recent head 35ded67. Consider uploading reports for the commit 35ded67 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1102      +/-   ##
==========================================
- Coverage   75.46%   75.44%   -0.03%     
==========================================
  Files         108      108              
  Lines        7679     7684       +5     
==========================================
+ Hits         5795     5797       +2     
- Misses       1329     1332       +3     
  Partials      555      555              
Impacted Files Coverage Δ
pkg/v1/remote/options.go 62.33% <0.00%> (-2.53%) ⬇️
pkg/v1/remote/list.go 75.60% <100.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54c3445...35ded67. Read the comment docs.

@alexey-igrychev alexey-igrychev marked this pull request as draft August 11, 2021 17:48
pkg/v1/remote/options.go Show resolved Hide resolved
pkg/v1/remote/options.go Show resolved Hide resolved
@alexey-igrychev alexey-igrychev marked this pull request as ready for review August 11, 2021 18:04
@alexey-igrychev
Copy link
Contributor Author

I apologise for my inattention

@jonjohnsonjr
Copy link
Collaborator

I apologise for my inattention

No problem, there's a lot of indirection going on, it's easy to get lost in it 😄

Copy link
Collaborator

@jonjohnsonjr jonjohnsonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonjohnsonjr jonjohnsonjr merged commit bcbf8d3 into google:main Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants