Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logic around whether an error is 'Temporary' #1115

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

DennisDenuto
Copy link
Contributor

Related to: #1113

Keeping this PR in draft since there are other details to discuss in #1113

Authored-by: Dennis Leon leonde@vmware.com

Authored-by: Dennis Leon <leonde@vmware.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2021

Codecov Report

Merging #1115 (7997b55) into main (7e0ed51) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1115   +/-   ##
=======================================
  Coverage   75.16%   75.16%           
=======================================
  Files         108      108           
  Lines        7724     7724           
=======================================
  Hits         5806     5806           
  Misses       1363     1363           
  Partials      555      555           
Impacted Files Coverage Δ
pkg/v1/remote/transport/error.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e0ed51...7997b55. Read the comment docs.

@jonjohnsonjr jonjohnsonjr merged commit 8388fde into google:main Sep 8, 2021
@DennisDenuto
Copy link
Contributor Author

@jonjohnsonjr

Thanks!! would you happen to have a ballpark estimate on when the next ggcr release will be?

We really really want this change to help with test flakiness we are experiencing and to include it in our next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants