Do not check /v2 endpoint on registry when RoundTripper is provided #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor tests that where Marshalling the transport.Error. This was causing staticcheck to fail. Instead of trying to Marshall the error we now provide the strings version of the expected errors. Signed-off-by: João Pereira <joaod@vmware.com>
When the calling the function NewWithContext, if the RoundTripper provided is of the type transport.Wrapper, the function will assume that the caller did the needed due diligence to ensure the registry supports OCI v2. In this case the function will only need to return back the provided RoundTripper without any further change. Signed-off-by: João Pereira <joaod@vmware.com>
|
Thanks! Do you mind splitting the staticcheck stuff out into a separate PR just so it's easier to revert the roundtripper change if we need to? |
|
I added the change in 2 separate commits, do you think that is enough or will you want the ability to roll back the PR to make it more trackable? |
|
Ah the two separate commits is fine! |
jonjohnsonjr
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
transport.Wrapperis provided to the functionNewWithContext, the function will assume that the called has already created the RoundTripper and made sure that the authentication happened and that the registry supports V2 of distribution spec.