match.Platforms and match.Digests

[deitch]

Option to:

• match.Platforms([]v1.Platform) for any one of them.
• match.Digest(v1.Hash)
• match.Digests([]v1.Hash) for any one of them.

Also tests, of course.

[deitch]

Updated to include match.Digest and match.Digests

[codecov-io]

Codecov Report

Merging #841 (3ff3c6f) into master (cf9d7b3) will decrease coverage by 0.38%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #841      +/-   ##
==========================================
- Coverage   74.72%   74.33%   -0.39%     
==========================================
  Files         106      106              
  Lines        4427     4458      +31     
==========================================
+ Hits         3308     3314       +6     
- Misses        629      651      +22     
- Partials      490      493       +3     

Impacted Files	Coverage Δ
pkg/v1/match/match.go	100.00% <100.00%> (ø)
pkg/v1/remote/transport/useragent.go	47.61% <0.00%> (-52.39%)	⬇️
pkg/crane/options.go	47.36% <0.00%> (-21.87%)	⬇️
pkg/v1/remote/transport/ping.go	86.95% <0.00%> (-8.70%)	⬇️
pkg/v1/remote/options.go	54.54% <0.00%> (-7.00%)	⬇️
pkg/gcrane/copy.go	84.37% <0.00%> (-1.14%)	⬇️
pkg/v1/remote/descriptor.go	73.78% <0.00%> (-0.61%)	⬇️
pkg/v1/remote/transport/basic.go	100.00% <0.00%> (ø)
pkg/v1/remote/transport/transport.go	100.00% <0.00%> (ø)
pkg/v1/remote/write.go	65.59% <0.00%> (+0.34%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf9d7b3...3ff3c6f. Read the comment docs.

[deitch]

Review, please @jonjohnsonjr ?

[jonjohnsonjr]

I'm kinda -1 on having both match.Foo and match.Foos for everything...

Option 1:

func Foo(foo Foo) Matcher
func Foos(foos []Foo) Matcher

Option 2:

// Clients have to use match.Foos([]Foo{foo})
func Foos(foos []Foo) Matcher

Option 3:

// Works with match.Foos(foo) and match.Foos(foo, bar)
func Foos(foos ...Foo) Matcher

Option 4:

// Works with match.Foo(foo) and match.Foo(foo, bar)
func Foo(foos ...Foo) Matcher

WDYT? Order of preference for me is probably 4, 3, 1, 2.

We already have match.MediaTypes for 2, but this has been merged for such a short window that I'd be fine making a breaking change for that to make it consistent.

[deitch]

Oh, yeah, I like 4. Variadic is so nice and easy. The question is, should it be named:

func Foo(foo Foo...) Matcher

or

func Foos(foo Foo...) Matcher

I think the second, since it can match multiple?

[jonjohnsonjr]

They're about equivalent to me, so whichever you prefer.

[deitch]

OK, updated @jonjohnsonjr ; take a look. I did MediaTypes too, as you suggested.