Use gcrane.Keychain for not only crane-inherit commands but also gcrane-specific commands. #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne-specific commands.
Codecov Report
@@ Coverage Diff @@
## master #880 +/- ##
=======================================
Coverage 74.33% 74.33%
=======================================
Files 107 107
Lines 4523 4523
=======================================
Hits 3362 3362
Misses 661 661
Partials 500 500 Continue to review full report at Codecov.
|
jonjohnsonjr
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#845 introduces
gcrane.Keychain.This PR uses
gcrane.Keychainfor not only crane-inherit commands(ex. pull) but also gcrane-specific commands(gc/ls).