"omitempty" does not work with non-pointer structs

[rehmsen]

This was reported and fixed for an individual case in #66. #66 (comment) lists a few more fields with the same problem, but that list is also not complete. As one more example, I ran into this for ErrorResponseBody.Error:

go-dap/schematypes.go

Line 104 in f58c894

Error ErrorMessage `json:"error,omitempty"`

The issue is that Go cannot set this fields to nil and will instead when parsing create an empty struct. Then when that message is serialized again, it will not be omitted as requested, but the empty values will be written to JSON, in my case leading to something like

"body":{"error":{"id":0,"format":"","showUser":false}}

instead of

"body":{}

and that then confuses VS Code and others.

I think the correct fix would be to go through and make all non-pointer struct fields that have omitempty on them, and turn them into pointers. Do you agree with this solution? Then I could look into preparing a PR for this.

[suzmue]

Thanks for the bug! That seems like a reasonable solution. Please feel free to send a PR.

[rehmsen]

Thanks for confirming Suzy. I have send you a PR. Would love your review!

I cannot edit assignee, it seems. Feel free to assign the issue to me.