SteppingGranularity is not a struct but a string alias and should not use a pointer

[rehmsen]

I think I found a bug in my own PR that is now released as v0.9.0:

go-dap/schematypes.go

Line 914 in d1322a7

Granularity *SteppingGranularity `json:"granularity,omitempty"`

But this is not actually a struct, so it does not need to be a pointer to be omitted from JSON:

go-dap/schematypes.go

Line 1880 in d1322a7

type SteppingGranularity string

I will look into a fix tomorrow.

[rehmsen]

Not all type aliases seem to be affected:

Affected types:

• CompletionItemType
• DataBreakpointAccessType
• SteppingGranularity

Not affected:

• ChecksumAlgorithm - because it is not optional
• ExceptionBreakMode - because it is not optional
• InvalidatedAreas - only used as slice elements - these do not need to be, and are not handled as struct pointers because the slice itself can be nil when omitted

The tricky part is that we process stuff in the order it is in the JSON file, so by the time a property of type SteppingGranularity is encountered and emitted, we have not yet parsed the definition of that type, so we do not know if it is going to be a struct or a primitive type alias.

One possibility would be to hard code the known type aliases somewhere - that does not feel ideal, but we are doing it already for cases where the spec defines an omitted optional boolean to be interpreted as true, and we used to also do this for structs.

The other option is to make a second pass to collect these before starting to emit in source order. It looks like we are anyways not streaming anything, and unmarshal all definitions before starting with any emitting here:

go-dap/cmd/gentypes/gentypes.go

Line 595 in d1322a7

if err := json.Unmarshal(m["definitions"], &typeMap); err != nil {