Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interfaces for Request, Response & Event #42

Merged
merged 2 commits into from
Jun 22, 2020
Merged

Interfaces for Request, Response & Event #42

merged 2 commits into from
Jun 22, 2020

Conversation

dbaumgarten
Copy link
Contributor

Implements #41

eliben
eliben reviewed Jun 1, 2020
View reviewed changes
cmd/gentypes/gentypes.go Outdated Show resolved Hide resolved
dbaumgarten added a commit to dbaumgarten/go-dap that referenced this pull request Jun 1, 2020
@dbaumgarten
Change EventMessage-method to return *Event google#42
5ab0bf8
polinasok
polinasok reviewed Jun 3, 2020
View reviewed changes
Copy link
Contributor

@polinasok polinasok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are still discussing the overall approach, but in case we decide to go for it, please see proposed changes in the comments.

cmd/gentypes/gentypes.go Outdated Show resolved Hide resolved
schematypes.go Show resolved Hide resolved
schematypes.go Outdated Show resolved Hide resolved
@eliben eliben mentioned this pull request Jun 5, 2020
Merged
@dbaumgarten
Copy link
Contributor Author

As #43 does change the way methods are emitted it would probably be the best to wait until it is merged and then rebase (and partly redo) this PR on it.

This would automatically solve most comments you made about this PR.

@polinasok polinasok mentioned this pull request Jun 9, 2020
Merged
@dbaumgarten dbaumgarten requested a review from eliben June 19, 2020 15:46
eliben
eliben suggested changes Jun 22, 2020
View reviewed changes
Copy link
Member

@eliben eliben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just a couple of minor comments and this should be good to go

cmd/gentypes/gentypes.go Show resolved Hide resolved
cmd/gentypes/gentypes.go Outdated Show resolved Hide resolved
@dbaumgarten dbaumgarten requested a review from eliben June 22, 2020 14:35
@eliben eliben merged commit eb49db5 into google:master Jun 22, 2020
@eliben eliben mentioned this pull request Jun 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polinasok polinasok polinasok left review comments

@eliben eliben Awaiting requested review from eliben

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dbaumgarten @eliben @polinasok