Refactor: Unify traversal through Field and FieldAddr instructions #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlevesquedion
commented
Dec 16, 2020
| @@ -41,7 +46,7 @@ func TestProtoStyleFieldAccessorPIISecondLevel(wrapper struct{ *core.Source }) { | |||
| core.Sinkf("Source id: %v", wrapper.Source.GetID()) | |||
| } | |||
|
|
|||
| func tesDirectFieldAccessorPIISecondLevel(wrapper struct{ *core.Source }) { | |||
| func TestDirectFieldAccessorPIISecondLevel(wrapper struct{ *core.Source }) { | |||
There was a problem hiding this comment.
Sorry for the drive-by, unrelated fix, but this bugs me every time I see it.
mlevesquedion
requested review from
PurelyApplied,
vinayakankugoyal and
benhxy
8 tasks
PurelyApplied
approved these changes
Dec 22, 2020
internal/pkg/levee/testdata/src/example.com/tests/fields/tests.go
Outdated
Show resolved
Hide resolved
mlevesquedion
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #188.
This PR uniformizes the way propagation works for
FieldandFieldAddrinstructions. While the dynamic semantics of these two instructions are a little different, for the purposes of our traversal they should be the handled the same way.I know we've recently been discussing (#195, #228) how we might need to rethink the way we handle fields, and I think unifying the way these instructions are handled is a necessary step towards that.