Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAR pointer analysis: add inter-procedural support #308

Merged
merged 8 commits into from
May 5, 2021

Conversation

guodongli-google
Copy link
Contributor

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

  • Running against a large codebase such as Kubernetes does not error out. (See DEVELOPING.md for instructions on how to do that.)
  • Appropriate changes to README are included in PR

internal/pkg/earpointer/analysis.go Outdated Show resolved Hide resolved
internal/pkg/earpointer/analysis.go Outdated Show resolved Hide resolved
internal/pkg/earpointer/analysis.go Outdated Show resolved Hide resolved
internal/pkg/earpointer/analysis.go Outdated Show resolved Hide resolved
internal/pkg/earpointer/analysis_test.go Show resolved Hide resolved
internal/pkg/earpointer/analysis.go Show resolved Hide resolved
internal/pkg/earpointer/analysis.go Outdated Show resolved Hide resolved
internal/pkg/earpointer/analysis.go Show resolved Hide resolved
internal/pkg/earpointer/analysis.go Outdated Show resolved Hide resolved
internal/pkg/earpointer/analysis.go Outdated Show resolved Hide resolved
internal/pkg/earpointer/analysis.go Outdated Show resolved Hide resolved
internal/pkg/earpointer/analysis.go Outdated Show resolved Hide resolved
internal/pkg/earpointer/analysis_test.go Outdated Show resolved Hide resolved
internal/pkg/earpointer/analysis_test.go Outdated Show resolved Hide resolved
internal/pkg/earpointer/analysis.go Outdated Show resolved Hide resolved
@guodongli-google
Copy link
Contributor Author

Somehow I can't add new reviewer into this PR. Can we add Tim as a reviewer?

@mlevesquedion
Copy link
Contributor

It seems I am unable to add him either. 🤔 If you send him a link to the PR he should be able to review it though.

@PurelyApplied
Copy link
Collaborator

PurelyApplied commented Apr 29, 2021

Somehow I can't add new reviewer into this PR. Can we add Tim as a reviewer?

I believe GitHub doesn't allow you to add someone to a PR until they are listed in that repo's history - usually as a contributor of at least one commit. Mentions should still show up in their notifications, though (maybe?). @timothy-king

internal/pkg/earpointer/analysis.go Outdated Show resolved Hide resolved
internal/pkg/earpointer/analysis.go Show resolved Hide resolved
internal/pkg/earpointer/analysis.go Outdated Show resolved Hide resolved
internal/pkg/earpointer/analysis.go Outdated Show resolved Hide resolved
internal/pkg/earpointer/analysis.go Outdated Show resolved Hide resolved
internal/pkg/earpointer/analysis_test.go Outdated Show resolved Hide resolved
internal/pkg/earpointer/analysis_test.go Outdated Show resolved Hide resolved
internal/pkg/earpointer/analysis_test.go Outdated Show resolved Hide resolved
internal/pkg/earpointer/analysis_test.go Show resolved Hide resolved
internal/pkg/earpointer/analysis_test.go Outdated Show resolved Hide resolved
internal/pkg/earpointer/heap.go Outdated Show resolved Hide resolved
Copy link
Contributor

@mlevesquedion mlevesquedion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe consider adding a test case with a recursive function.

@guodongli-google
Copy link
Contributor Author

LGTM.

Maybe consider adding a test case with a recursive function.

Such a test has been added.
More tests about function/method calls will come in the next PR.

internal/pkg/earpointer/analysis.go Outdated Show resolved Hide resolved
Copy link
Member

@timothy-king timothy-king left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlevesquedion mlevesquedion merged commit 3eeb5c6 into google:master May 5, 2021
@guodongli-google guodongli-google deleted the EAR-inter branch May 5, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants