Skip to content

Commit

Permalink
Add NestedTeamsPreview header to remaining endpoints
Browse files Browse the repository at this point in the history
Fixes #714.
  • Loading branch information
elliott-beach authored and dmitshur committed Oct 16, 2017
1 parent beb277c commit 5c20fe5
Show file tree
Hide file tree
Showing 6 changed files with 25 additions and 4 deletions.
13 changes: 11 additions & 2 deletions github/orgs_teams.go
Expand Up @@ -8,6 +8,7 @@ package github
import (
"context"
"fmt"
"strings"
"time"
)

Expand Down Expand Up @@ -195,6 +196,8 @@ func (s *OrganizationsService) DeleteTeam(ctx context.Context, team int) (*Respo
return nil, err
}

req.Header.Set("Accept", mediaTypeNestedTeamsPreview)

return s.client.Do(ctx, req, nil)
}

Expand Down Expand Up @@ -224,6 +227,8 @@ func (s *OrganizationsService) ListTeamMembers(ctx context.Context, team int, op
return nil, nil, err
}

req.Header.Set("Accept", mediaTypeNestedTeamsPreview)

var members []*User
resp, err := s.client.Do(ctx, req, &members)
if err != nil {
Expand Down Expand Up @@ -264,7 +269,8 @@ func (s *OrganizationsService) ListTeamRepos(ctx context.Context, team int, opt
}

// TODO: remove custom Accept header when topics API fully launches.
req.Header.Set("Accept", mediaTypeTopicsPreview)
headers := []string{mediaTypeTopicsPreview, mediaTypeNestedTeamsPreview}
req.Header.Set("Accept", strings.Join(headers, ", "))

var repos []*Repository
resp, err := s.client.Do(ctx, req, &repos)
Expand All @@ -287,7 +293,8 @@ func (s *OrganizationsService) IsTeamRepo(ctx context.Context, team int, owner s
return nil, nil, err
}

req.Header.Set("Accept", mediaTypeOrgPermissionRepo)
headers := []string{mediaTypeOrgPermissionRepo, mediaTypeNestedTeamsPreview}
req.Header.Set("Accept", strings.Join(headers, ", "))

repository := new(Repository)
resp, err := s.client.Do(ctx, req, repository)
Expand Down Expand Up @@ -377,6 +384,8 @@ func (s *OrganizationsService) GetTeamMembership(ctx context.Context, team int,
return nil, nil, err
}

req.Header.Set("Accept", mediaTypeNestedTeamsPreview)

t := new(Membership)
resp, err := s.client.Do(ctx, req, t)
if err != nil {
Expand Down
10 changes: 8 additions & 2 deletions github/orgs_teams_test.go
Expand Up @@ -11,6 +11,7 @@ import (
"fmt"
"net/http"
"reflect"
"strings"
"testing"
"time"
)
Expand Down Expand Up @@ -159,6 +160,7 @@ func TestOrganizationsService_DeleteTeam(t *testing.T) {

mux.HandleFunc("/teams/1", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "DELETE")
testHeader(t, r, "Accept", mediaTypeNestedTeamsPreview)
})

_, err := client.Organizations.DeleteTeam(context.Background(), 1)
Expand All @@ -173,6 +175,7 @@ func TestOrganizationsService_ListTeamMembers(t *testing.T) {

mux.HandleFunc("/teams/1/members", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "GET")
testHeader(t, r, "Accept", mediaTypeNestedTeamsPreview)
testFormValues(t, r, values{"role": "member", "page": "2"})
fmt.Fprint(w, `[{"id":1}]`)
})
Expand Down Expand Up @@ -296,7 +299,8 @@ func TestOrganizationsService_ListTeamRepos(t *testing.T) {

mux.HandleFunc("/teams/1/repos", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "GET")
testHeader(t, r, "Accept", mediaTypeTopicsPreview)
acceptHeaders := []string{mediaTypeTopicsPreview, mediaTypeNestedTeamsPreview}
testHeader(t, r, "Accept", strings.Join(acceptHeaders, ", "))
testFormValues(t, r, values{"page": "2"})
fmt.Fprint(w, `[{"id":1}]`)
})
Expand All @@ -319,7 +323,8 @@ func TestOrganizationsService_IsTeamRepo_true(t *testing.T) {

mux.HandleFunc("/teams/1/repos/o/r", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "GET")
testHeader(t, r, "Accept", mediaTypeOrgPermissionRepo)
acceptHeaders := []string{mediaTypeOrgPermissionRepo, mediaTypeNestedTeamsPreview}
testHeader(t, r, "Accept", strings.Join(acceptHeaders, ", "))
fmt.Fprint(w, `{"id":1}`)
})

Expand Down Expand Up @@ -451,6 +456,7 @@ func TestOrganizationsService_GetTeamMembership(t *testing.T) {

mux.HandleFunc("/teams/1/memberships/u", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "GET")
testHeader(t, r, "Accept", mediaTypeNestedTeamsPreview)
fmt.Fprint(w, `{"url":"u", "state":"active"}`)
})

Expand Down
2 changes: 2 additions & 0 deletions github/repos.go
Expand Up @@ -481,6 +481,8 @@ func (s *RepositoriesService) ListTeams(ctx context.Context, owner string, repo
return nil, nil, err
}

req.Header.Set("Accept", mediaTypeNestedTeamsPreview)

var teams []*Team
resp, err := s.client.Do(ctx, req, &teams)
if err != nil {
Expand Down
2 changes: 2 additions & 0 deletions github/repos_collaborators.go
Expand Up @@ -41,6 +41,8 @@ func (s *RepositoriesService) ListCollaborators(ctx context.Context, owner, repo
return nil, nil, err
}

req.Header.Set("Accept", mediaTypeNestedTeamsPreview)

var users []*User
resp, err := s.client.Do(ctx, req, &users)
if err != nil {
Expand Down
1 change: 1 addition & 0 deletions github/repos_collaborators_test.go
Expand Up @@ -20,6 +20,7 @@ func TestRepositoriesService_ListCollaborators(t *testing.T) {

mux.HandleFunc("/repos/o/r/collaborators", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "GET")
testHeader(t, r, "Accept", mediaTypeNestedTeamsPreview)
testFormValues(t, r, values{"page": "2"})
fmt.Fprintf(w, `[{"id":1}, {"id":2}]`)
})
Expand Down
1 change: 1 addition & 0 deletions github/repos_test.go
Expand Up @@ -404,6 +404,7 @@ func TestRepositoriesService_ListTeams(t *testing.T) {

mux.HandleFunc("/repos/o/r/teams", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "GET")
testHeader(t, r, "Accept", mediaTypeNestedTeamsPreview)
testFormValues(t, r, values{"page": "2"})
fmt.Fprint(w, `[{"id":1}]`)
})
Expand Down

0 comments on commit 5c20fe5

Please sign in to comment.