refactor: use values instead of pointers

google · Jul 9, 2022 · e578227 · e578227
1 parent 595a023
commit e578227
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 19 deletions.
diff --git a/github/repos_codeowners.go b/github/repos_codeowners.go
@@ -17,13 +17,13 @@ type CodeownersErrors struct {
 
 // CodeownersError represents a syntax error detected in the CODEOWNERS file.
 type CodeownersError struct {
-	Line       *int    `json:"line"`
-	Column     *int    `json:"column"`
-	Kind       *string `json:"kind"`
-	Source     *string `json:"source"`
-	Suggestion *string `json:"suggestion"`
-	Message    *string `json:"message"`
-	Path       *string `json:"path"`
+	Line       int     `json:"line"`
+	Column     int     `json:"column"`
+	Kind       string  `json:"kind"`
+	Source     string  `json:"source"`
+	Suggestion *string `json:"suggestion,omitempty"`
+	Message    string  `json:"message"`
+	Path       string  `json:"path"`
 }
 
 // GetCodeownersErrors lists any syntax errors that are detected in the CODEOWNERS file.

diff --git a/github/repos_codeowners_test.go b/github/repos_codeowners_test.go
@@ -46,13 +46,13 @@ func TestRepositoriesService_GetCodeownersErrors(t *testing.T) {
 	want := &CodeownersErrors{
 		Errors: []*CodeownersError{
 			{
-				Line:       Int(1),
-				Column:     Int(1),
-				Kind:       String("Invalid pattern"),
-				Source:     String("***/*.rb @monalisa"),
+				Line:       1,
+				Column:     1,
+				Kind:       "Invalid pattern",
+				Source:     "***/*.rb @monalisa",
 				Suggestion: String("Did you mean **/*.rb?"),
-				Message:    String("Invalid pattern on line 3: Did you mean **/*.rb?\n\n  ***/*.rb @monalisa\n  ^"),
-				Path:       String(".github/CODEOWNERS"),
+				Message:    "Invalid pattern on line 3: Did you mean **/*.rb?\n\n  ***/*.rb @monalisa\n  ^",
+				Path:       ".github/CODEOWNERS",
 			},
 		},
 	}
@@ -81,13 +81,13 @@ func TestCodeownersErrors_Marshal(t *testing.T) {
 	u := &CodeownersErrors{
 		Errors: []*CodeownersError{
 			{
-				Line:       Int(1),
-				Column:     Int(1),
-				Kind:       String("Invalid pattern"),
-				Source:     String("***/*.rb @monalisa"),
+				Line:       1,
+				Column:     1,
+				Kind:       "Invalid pattern",
+				Source:     "***/*.rb @monalisa",
 				Suggestion: String("Did you mean **/*.rb?"),
-				Message:    String("Invalid pattern on line 3: Did you mean **/*.rb?\n\n  ***/*.rb @monalisa\n  ^"),
-				Path:       String(".github/CODEOWNERS"),
+				Message:    "Invalid pattern on line 3: Did you mean **/*.rb?\n\n  ***/*.rb @monalisa\n  ^",
+				Path:       ".github/CODEOWNERS",
 			},
 		},
 	}