Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add security_advisory and code_scanning_alert event types #2306

Closed
uptycs-rmack opened this issue Mar 1, 2022 · 7 comments · Fixed by #2311
Closed

Please add security_advisory and code_scanning_alert event types #2306

uptycs-rmack opened this issue Mar 1, 2022 · 7 comments · Fixed by #2311

Comments

@uptycs-rmack
Copy link

These two event types would be very useful to be able to receive through the webhook API.

https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#security_advisory

https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#code_scanning_alert

Thanks, Ryan

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 2, 2022

Thank you, @uptycs-rmack - would you like to create a PR, or would you like me to open this up to other contributors to this repo?
If you are planning on writing one, please check out our CONTRIBUTING.md guide.

@uptycs-rmack
Copy link
Author

uptycs-rmack commented Mar 2, 2022

I'm fairly new to golang so I'm not my first choice to work on this but if you don't think there would be much interest from anyone else I'm sure I can muddle though. What would you recommend?

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 2, 2022

I'm fairly new to golang so I'm not my first choice to work on this but if you don't think there would be much interest from anyone else on it I'm sure I can muddle though. What would you recommend?

Thanks, @uptycs-rmack - no need to muddle through... we have lots of eager contributors to this repo who are happy to help out. I'll open it up.

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 2, 2022

This would be a great PR for any new contributor to this repo or a new Go developer.
All contributions are greatly appreciated!

Feel free to volunteer for any issue and the issue can be assigned to you so that others don't attempt to duplicate the work.

Please check out our CONTRIBUTING.md guide to get started. (In particular, please remember to go generate ./... and don't use force-push to your PRs.)

Thank you!

@sourikghosh
Copy link
Contributor

@gmlewis I will be more than happy to work on this.

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 2, 2022

@gmlewis I will be more than happy to work on this.

Thank you, @sourikghosh ! It's yours.

@uptycs-rmack
Copy link
Author

Thank you @gmlewis and @sourikghosh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants