Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewTeam missing notification_setting field #3107

Closed
ggabijaa opened this issue Mar 19, 2024 · 1 comment · Fixed by #3111
Closed

NewTeam missing notification_setting field #3107

ggabijaa opened this issue Mar 19, 2024 · 1 comment · Fixed by #3111
Assignees

Comments

@ggabijaa
Copy link

When creating a new team Github API let's to disable notifications for the team by setting notification_setting to notifications_disabled.
https://docs.github.com/en/rest/teams/teams?apiVersion=2022-11-28#create-a-team

However, this field is missing from NewTeam struct and prevents disabling it
https://pkg.go.dev/github.com/google/go-github/v60@v60.0.0/github#NewTeam

Would it be possible to add it?

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 19, 2024

Absolutely! Would you like to create a PR, or shall I open this up to our other contributors to this repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants