New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add document for query of search functions #1300
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #1300 +/- ##
=======================================
Coverage 73.42% 73.42%
=======================================
Files 86 86
Lines 6047 6047
=======================================
Hits 4440 4440
Misses 837 837
Partials 770 770
Continue to review full report at Codecov.
|
github/search.go
Outdated
@@ -24,6 +24,10 @@ import ( | |||
// will search for such issues, sorting by creation date in ascending order | |||
// (i.e., oldest first). | |||
// | |||
// If query includes multiple condition, it MUST NOT include "+" as condition separator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Could you please tweak this slightly so that it is easier to read? How about:
// If query includes multiple conditions, it MUST NOT include "+" as the condition separator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, i will add more detail (using " " instead) to the documentation. Thanks for your review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @iamquang95!
LGTM.
Merging.
Closes #1266. |
* Add document for search query * Add more detail of using search query
Addressed the document part of #1266