Add ListOptions to ListSelectedReposForOrgSecret #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmlewis
added
the
Breaking API Change
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1883 +/- ##
=======================================
Coverage 97.65% 97.65%
=======================================
Files 105 105
Lines 6783 6786 +3
=======================================
+ Hits 6624 6627 +3
Misses 86 86
Partials 73 73
Continue to review full report at Codecov.
|
|
Thank you, @wesleimp ! |
|
@gmlewis can we get a fresh release please? |
Sure, @patrickmarabeas - feel free to LGTM/Approve #1921 to move the process along. |
|
https://github.com/google/go-github/releases/tag/v36.0.0 has been released. |
xun-guo-anzx
added a commit
to xun-guo-anzx/terraform-provider-github
that referenced
this pull request
Jun 30, 2021
* Update go-github to 36.0.0 go-github released the Go client library to [36.0.0][1] 3 days ago. API changes includes: * Add ListOptions required by ListSelectedReposForOrgSecret method. As described in change[2] * Convert repoID used in CreateOrUpdateEnvSecret, GetEnvSecret and DeleteEnvSecret to int from int64. Not sure why it doesn't pop up an error before but seems like this is not a recent change in the new version [1]: https://github.com/google/go-github/releases/tag/v36.0.0 [2]: google/go-github#1883
jcudit
pushed a commit
to integrations/terraform-provider-github
that referenced
this pull request
Jul 12, 2021
* Update go-github version to 36.0.0 * Update go-github to 36.0.0 go-github released the Go client library to [36.0.0][1] 3 days ago. API changes includes: * Add ListOptions required by ListSelectedReposForOrgSecret method. As described in change[2] * Convert repoID used in CreateOrUpdateEnvSecret, GetEnvSecret and DeleteEnvSecret to int from int64. Not sure why it doesn't pop up an error before but seems like this is not a recent change in the new version [1]: https://github.com/google/go-github/releases/tag/v36.0.0 [2]: google/go-github#1883 * Fetch full list of selected repos in github_actions_organization_secret Fix #793
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
* Update go-github version to 36.0.0 * Update go-github to 36.0.0 go-github released the Go client library to [36.0.0][1] 3 days ago. API changes includes: * Add ListOptions required by ListSelectedReposForOrgSecret method. As described in change[2] * Convert repoID used in CreateOrUpdateEnvSecret, GetEnvSecret and DeleteEnvSecret to int from int64. Not sure why it doesn't pop up an error before but seems like this is not a recent change in the new version [1]: https://github.com/google/go-github/releases/tag/v36.0.0 [2]: google/go-github#1883 * Fetch full list of selected repos in github_actions_organization_secret Fix integrations#793
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1882.