-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test cases for JSON resource marshaling #1975
Conversation
- InteractionRestriction
Codecov Report
@@ Coverage Diff @@
## master #1975 +/- ##
=======================================
Coverage 97.84% 97.84%
=======================================
Files 105 105
Lines 6809 6809
=======================================
Hits 6662 6662
Misses 80 80
Partials 67 67 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @sagar23sj !
One minor tweak to fix, please, and then it LGTM.
Whenever a new file is created, we use the year it was created as its copyright year.
github/interactions_test.go
Outdated
@@ -0,0 +1,26 @@ | |||
// Copyright 2018 The go-github AUTHORS. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Copyright 2018 The go-github AUTHORS. All rights reserved. | |
// Copyright 2021 The go-github AUTHORS. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure @gmlewis. Will make the change.
Thank you for your instantaneous feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @sagar23sj !
LGTM.
Awaiting second LGTM before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Resources Covered :
Helps with issue: #55