-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecated field #2017
Fix deprecated field #2017
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2017 +/- ##
=======================================
Coverage 97.86% 97.86%
=======================================
Files 107 107
Lines 6897 6901 +4
=======================================
+ Hits 6750 6754 +4
Misses 81 81
Partials 66 66
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @ganeshkumarsv !
LGTM.
Awaiting second LGTM due to breaking API change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@gmlewis Thank you for approving & merging the PR. Can I know when the next release will be created for go-github? |
No problem. I should be able to cut a new release by tomorrow. |
awesome! Thank you! |
@ganeshkumarsv - v38 has now been released. |
The deprecated field
open
got changed tostate
to hold 3 different values (open, dismissed, and fixed
)